-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted #62
Comments
cc @kasperisager @mafintosh because you added |
@bmackio @vweevers If this can be fixed without |
Would something like this work? node-gyp-build/node-gyp-build.js Lines 5 to 6 in 2f0695e
|
We can try for sure |
Can someone verify if this fixes the issue: #63 |
@mafintosh injecting that code did not work locally on my machine. I think the issue is the conditional as I'm going to lookin into the following code on
|
I could not find where the warning gets triggered in |
The issue could be due to a modified output in the build: webpack/webpack#16793 I'll continue to investigate as I have time, but need to get back to what I was doing. If anyone can identify the way in which next/typescript changes the |
If I do a static build, by adding:
My
|
If you give me a command on how to repro that error/warning locally, I'm happy to iterate here also |
@mafintosh, here's a repo @taychris created: https://github.com/taychris/nextjs-supabase |
Any idea of how to surpress this warning in the meantime? |
@samducker You can pin to |
Thank you, this fixed my issues! |
Fixed in 4.7.1 |
If anyone can repro please post here how after (you need to remove that .next cache mb, i had to) |
Bug report
Describe the bug
I'm receiving this warning (wasn't receiving previous to reinstalling from package.json):
When I uninstall
"@supabase/supabase-js": "^2.33.1",
from the app and remove the client code:The warning goes away.
To Reproduce
next dev
Expected behavior
I expect there to be no warning as nothing seems to be wrong with the code in node-gyp (however I could be wrong) which is added by
websocket
:System information
Additional context
Let me know if you have any insights on how to remedy or turn off the warning
The text was updated successfully, but these errors were encountered: