Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request isolates version-specific changes into separate files included at compile-time (we could even say "configuration-time"), trying to unify all the different variants of the adapter we are currently offering as branches. See #32 for a discussion of the problem (closes #32).
Motivation:
#include "file.H"
.Idea:
variants/<variant>/version-specific/
.#include "version-specific/file.H"
.<variant>
we always take the$WM_PROJECT_VERSION
. We only treat it as a string as it varies a lot among versions.Pros & Cons of this approach:
.boundaryField()
and.boundaryFieldRef()
.Todo:
Before merging, check that the final version builds with:
External updates:
Possible next steps:
pimpleFoam
andpimpleDyMFoam
in the tutorial scripts. Maybe simply apply a special case for the oldest supported versions.