Update adapter-calculix-get-calculix.md #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of writing this, {{site.calculix_version}} points to 2.2 which is wrong and makes the links broken. If it points to 2.20 then there will be no problem. For the time being I change {{site.calculix_version}} to 2.20 which is not the smartest thing to do but solves the issue anyway.
Also there is typo in "Summary". I changed "challenges" to "challenge".
MakisH
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Thank you for reporting and trying to fix! 😄
The issue was not a hard-coded 2.2, but a more sneaky Jekyll feature: https://stackoverflow.com/questions/37862167/trailing-zeros-in-jekyll-liquid
I fixed it by converting the respective version to a string. I did not touch the precice_version, as I am not sure if it could have any side-effects (and it does not seem to be affected at the moment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of writing this, {{site.calculix_version}} points to 2.2 which is wrong and makes the links broken. If it points to 2.20 then there will be no problem. For the time being I change {{site.calculix_version}} to 2.20 which is not the smartest thing to do but solves the issue anyway. Also there is typo in "Summary". I changed "challenges" to "challenge".