Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port trivial cases #151

Merged
merged 26 commits into from
Feb 19, 2021
Merged

Port trivial cases #151

merged 26 commits into from
Feb 19, 2021

Conversation

davidscn
Copy link
Member

@davidscn davidscn commented Jan 28, 2021

Closes #134

  • flow-over-heated-plate-steady-state
    • README
    • test code_aster case (I have no installation)
  • heat-exchanger
    • README
  • elastic-tube-3d
    • README
  • multiple-perpendicular-flaps
    • README
  • partitioned-elastic-beam
    • README

@davidscn davidscn linked an issue Jan 28, 2021 that may be closed by this pull request
5 tasks
@uekerman
Copy link
Member

Although various cases were previously bad documented and I don't want to write the documentation for all of these cases.

Could you please split up the TODO above into one per case and let us know in which status each README is. We could then try to distribute the work there.

@davidscn davidscn mentioned this pull request Feb 5, 2021
@davidscn davidscn self-assigned this Feb 11, 2021
@davidscn
Copy link
Member Author

@MakisH may I ask you to test the code_aster tutorial? I think it will currently not work since there are specific requirements for the exchange directory (potentially incompatible with other solvers which we currently don't have).

@MakisH
Copy link
Member

MakisH commented Feb 11, 2021

I also don't have code_aster installed at the moment to test it, but I should eventually include it in the VM. Have you tested it in the meantime? I guess having someone else to also go through the docs would be useful: https://github.com/precice/code_aster-adapter/wiki/Flow-over-plate-Code_Aster-Tutorial

The main things that are special are:

  • that the user needs to set an absolute path as an exchange directory (we already specify this in the docs)
  • that the case is steady-state.

I don't think I will have time to look into code_aster until after the workshop.

@davidscn
Copy link
Member Author

I also don't have code_aster installed at the moment to test it, but I should eventually include it in the VM. Have you tested it in the meantime? I guess having someone else to also go through the docs would be useful: https://github.com/precice/code_aster-adapter/wiki/Flow-over-plate-Code_Aster-Tutorial

I have already ported the docs to the new website.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestion on "multiple flaps". Similarly, the preCICE config of "partitioned elastic beam" and "flow-over-heated-plate" needs to be ported. The latter, in particular, needs to be changed to 2D.

@uekerman
Copy link
Member

I also don't have code_aster installed at the moment to test it, but I should eventually include it in the VM. Have you tested it in the meantime? I guess having someone else to also go through the docs would be useful: https://github.com/precice/code_aster-adapter/wiki/Flow-over-plate-Code_Aster-Tutorial

I guess what @MakisH meant is to try them out 😁

@uekerman
Copy link
Member

Let's ignore the Code_Aster case here and do it after merging: #155.

@uekerman uekerman merged commit 79e9fc5 into precice:restructure Feb 19, 2021
@uekerman uekerman mentioned this pull request Mar 24, 2021
@davidscn davidscn deleted the port-trivial branch January 23, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port trivial cases to new tutorial structure
3 participants