Skip to content

Fixes for solid-codeaster #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2021
Merged

Fixes for solid-codeaster #201

merged 6 commits into from
Apr 13, 2021

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Apr 13, 2021 •
edited
Loading

Work together with @IshaanDesai. I guess that these changes are enough to make the code_aster adapter work with the new structure of the tutorials.

  • Add an empty REPE_OUT directory for the results.
  • Add a warning that the exchange-directory needs to be absolute.
  • Update solid.astk with new defaults.
  • Switch interface dimensions back to 3D.

Closes #155. Also related to precice/code_aster-adapter#22.

@MakisH MakisH self-assigned this Apr 13, 2021
@MakisH MakisH requested a review from IshaanDesai April 13, 2021 17:56
@MakisH MakisH marked this pull request as ready for review April 13, 2021 17:57
@MakisH
Copy link
Member Author

MakisH commented Apr 13, 2021

@IshaanDesai Ready for review from my side, everything looks as intended.

IshaanDesai
IshaanDesai approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I ran this case and checked the output in GMSH, it works.

@MakisH MakisH merged commit b2d1d64 into develop Apr 13, 2021
@MakisH MakisH deleted the fix-code-aster branch April 13, 2021 19:10
@IshaanDesai IshaanDesai mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IshaanDesai IshaanDesai IshaanDesai approved these changes

Assignees

@MakisH MakisH

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MakisH @IshaanDesai