Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a .gitignore and clean-up #477

Merged
merged 22 commits into from
Mar 12, 2024
Merged

Add a .gitignore and clean-up #477

merged 22 commits into from
Mar 12, 2024

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Mar 10, 2024

  • Adds a central .gitignore, taking into account all solvers we currently support, and all rules we have already defined in cleaning-tools.sh.
  • Adds individual .gitignore files in special cases, mainly where we download files from external repositories: aste-turbine, heat-exchanger.
  • Restores some Make/ directory unintentionally deleted in Follow naming convention in partitioned heat conduction - FEniCS #459 and fixes the corresponding .gitignore. (cc @BenjaminRodenberg)

Also adds a comments on instructions to do a deep clean, as at the moment all externally downloaded files, python virtual environments, and C++ code builds are not deleted by the cleaning scripts (and one generally should not need to delete them). I already tried extending the cleaning scripts for this purpose, but it was easy to make them unnecessarily more complex.

Also, general cleanup:

  • A stray reference-data is renamed to reference-results (cc @valentin-seitz)
  • Improves the readability of the cleaning scripts, so that at least when everything is clean, one can easily see if something is wrong.
  • Adds exceptions for the solver-* directories, to avoid the expected skipping messages.

@IshaanDesai @Fujikawas how do you like this change? Anything I have missed?

I did not really try running anything DUNE-related, but I guess it is covered.

closes #87

@MakisH MakisH added this to the v202403.0 milestone Mar 10, 2024
@MakisH MakisH self-assigned this Mar 10, 2024
@MakisH MakisH requested review from Fujikawas and IshaanDesai March 10, 2024 19:38
@MakisH MakisH mentioned this pull request Mar 11, 2024
@Fujikawas
Copy link
Contributor

but I guess it is covered.

Thank you doing this, I think all the folders and files to be removed relating to dunefem and dumux has been covered.

Copy link
Member

@IshaanDesai IshaanDesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Member

@fsimonis fsimonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all sane to me

@MakisH MakisH merged commit 4f74ac2 into precice:develop Mar 12, 2024
3 checks passed
@MakisH MakisH deleted the gitignore branch March 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants