-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a .gitignore and clean-up #477
Conversation
Unintentionally deleted in precice#459 as a result of a wrong gitignore
Thank you doing this, I think all the folders and files to be removed relating to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all sane to me
.gitignore
, taking into account all solvers we currently support, and all rules we have already defined incleaning-tools.sh
..gitignore
files in special cases, mainly where we download files from external repositories:aste-turbine
,heat-exchanger
.Make/
directory unintentionally deleted in Follow naming convention in partitioned heat conduction - FEniCS #459 and fixes the corresponding.gitignore
. (cc @BenjaminRodenberg)Also adds a comments on instructions to do a deep clean, as at the moment all externally downloaded files, python virtual environments, and C++ code builds are not deleted by the cleaning scripts (and one generally should not need to delete them). I already tried extending the cleaning scripts for this purpose, but it was easy to make them unnecessarily more complex.
Also, general cleanup:
reference-data
is renamed toreference-results
(cc @valentin-seitz)solver-*
directories, to avoid the expectedskipping
messages.@IshaanDesai @Fujikawas how do you like this change? Anything I have missed?
I did not really try running anything DUNE-related, but I guess it is covered.
closes #87