Add Fortran elastic-tube-1d solvers #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YonatanGM
changed the title
3 tasks
…nsistent precision
YonatanGM
force-pushed
the
elastic-tube-1d-fortran
branch
from
68d9d0f to
54b8cfa
Compare
MakisH
reviewed
Jan 29, 2025
Co-authored-by: Gerasimos Chourdakis <gerasimos.chourdakis@ipvs.uni-stuttgart.de>
MakisH
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Another very nice contribution, similarly to #607. Thank you, @YonatanGM!
I compared the directories for the implementation with and without the module, all look good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Fortran solvers for elastic-tube-1d case using the Fortran bindings (not the Fortran module). I opened another PR #607 with the module approach if you prefer that
The solvers follow the same project structure as the other solvers. LAPACK is needed for the fluid solver (same as the C++ case). Run ./run.sh to compile and execute the solvers via CMake. The plotting scripts (plot-diameter.sh and plot-all.sh) are updated to show results for the Fortran case. The precommit yaml didnt have hooks for Fortran files, so I maunally formatted them using fprettify.
Results look consistent with the other solvers. I checked the VTK output, and the numbers match up to 5 decimal places on the last timestep. Also tested running the fortran case against the other solves and that seems to work fine too.
Results:
Checklist:
changelog-entries/<PRnumber>.md.