-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dealii tutorials for new solver #79
Conversation
@uekerman @MakisH I think we should remove the 3D (quasi 2D) examples here. They are a great example of how it shouldn't be done, since the amount of work in the solid solver is much larger. Example: For a simple mesh with 150 cells and a polynomial degree of 4 I obtain 5 082 unknowns. The same mesh has in 3D 38 115 unknowns. Also, the cases are a duplication. Opinions? |
These are the only 2D cases we have and with these tutorials we mainly want to teach users how to configure preCICE for 2D (and showcase that the OpenFOAM adapter can also work in quasi-2D). You write
Do you have any alternative solution in mind so that we can still offer a (better, if possible) 2D-2D tutorial case? |
Sorry, I was a bit unclear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few questions that I got looking at the changes, maybe not all of them are action items.
Oh, I see, I misunderstood it as "remove the 2D". I don't see any strong reason not to remove the 3D deal.ii cases, but also not a strong reason to remove them. I guess that the 2D is the case adding value for our tutorials, and the 3D is maybe indeed duplicate from the deal.ii side. We should just make sure to document that 3D is also possible and how. |
This is now ready to run with the current deal adapter. I also added a |
I also don't see any strong reason why to remove the 3D case. I would see it as an example how to best approach these cases, but how to work with the dealii solver in 3D. And we have it tested then. Eventually, we will need to reorganize our tutorials anyway, but that's the story for another day :) |
Ok, then I need to update the nonlinear solver to cope with 3d and update the 3d tutorial cases here as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran the 2D tutorials. A few small things:
- dealii adapter does not build with dealii v9.1.1 (I already talked with @davidscn about this, just for completeness)
flap_perp_2D/OpenFOAM-deal.II/Fluid/system/preciceDict
still usesForce
instead ofStress
cylinderFlap_2D
is missing therunSolid
script./runFluid -parallel
does not work due to the write-consistent mapping. We need to move the mapping to the other participant if we use stresses.
The non-linear solver already for the flap is extremely slow. Any simple ideas how to speed this up? Maybe a coarser mesh?
So, currently only the linear solver supports 3D, not the nonlinear solver, correct? |
One more thing: if we use stresses we currently need the develop version of the OpenFOAM adapter, but this PR goes to the master branch. |
I just now merged it. |
Do you run the 2D case? Running it in release is considerably faster. I should set it as the default build option.
That's more a matter of the setup. I have already tested it once for three 3D, but discarded it.
Please merge the OpenFOAM version to master, there is also an open PR for a systemtest dev->master update and the deal.II adapter needs it in master as well (which is also the target). |
For the system tests, I would prefer to leave the decision to @Eder-K |
That's the case, see precice/systemtests#230
Perfect, this will probably fix the failing build there as well. |
There were some unstaged changes. I added now a .gitignore in these cases in order to avoid it. |
If you mean for dealii then yes 👍 |
You run it in
I updated now everything. Only the |
Just talked with @davidscn |
@uekerman I forgot one thing: Are you able to open up the generated |
I can open them, but I only get point data (which I can visualize with the glyph filter), but no cell data. Btw, |
Ok, no need to hurry, let's discuss it during the next meeting. Your version would be too old. |
Updates the tutorials according to precice/dealii-adapter#26.
The solver apply now stress data instead of force as provided in precice/openfoam-adapter#125.
#77 Becomes a separate PR, since it might take some time to investigate the appropriate parameters.