Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia bindings to vm #48

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Add Julia bindings to vm #48

merged 7 commits into from
Nov 15, 2022

Conversation

erikscheurer
Copy link
Contributor

The Julia bindings are released now, this PR adds them to the VM.
Installing Julia uses jill.py. This is not an official source, but one that allows for installation in a script without manually confirming as well as automatically using the latest Julia release. The Julialang download site and the Julia versioning manager don't allow for this.

Vagrantfile Outdated Show resolved Hide resolved
@erikscheurer
Copy link
Contributor Author

erikscheurer commented Oct 1, 2022

For the Julia bindings we are currently facing an issue with the installation of the bindings in Ubuntu 22.04. Since we are currently working out a solution, I don't have a permanent fix yet. (And you only notice the error when testing the bindings, which is why I included the commented tests here)
For now, the fix seems to be to build preCICE from source (which we do here already) and then start Julia with preloading: LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libstdc++.so.6 ./julia
Should we already include this in this PR?

@MakisH
Copy link
Member

MakisH commented Oct 5, 2022

For the Julia bindings we are currently facing an issue with the installation of the bindings in Ubuntu 22.04. Since we are currently working out a solution, I don't have a permanent fix yet. (And you only notice the error when testing the bindings, which is why I included the commented tests here) For now, the fix seems to be to build preCICE from source (which we do here already) and then start Julia with preloading: LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libstdc++.so.6 ./julia Should we already include this in this PR?

We generally don't run tests in this VM, to keep the build time as short as possible (it is already pretty long).

Currently, the VM is still using Ubuntu 20.04 and the upcoming release will also use 20.04. So, nothing to do now, but this comment will be relevant for #45.

I guess we need to set LD_PRELOAD every time we start Julia, right? In this case, we could make an alias for julia, to always set this.

@MakisH MakisH marked this pull request as draft October 5, 2022 08:43
@MakisH MakisH marked this pull request as ready for review October 5, 2022 08:43
@MakisH
Copy link
Member

MakisH commented Oct 5, 2022

Building currently fails because of the master->main branch renaming of preCICE. I have fixed that in other branches, but I should probably bring the fix to develop. In the meantime, feel free to rename it yourself and trigger the build by marking the PR as draft and then ready for review again.

Edit: I fixed on develop, feel free to rebase.

@MakisH MakisH changed the base branch from main to develop October 7, 2022 06:54
@MakisH MakisH marked this pull request as draft October 7, 2022 06:54
@MakisH MakisH marked this pull request as ready for review October 7, 2022 06:54
@MakisH
Copy link
Member

MakisH commented Oct 7, 2022

Building currently seems to fail at downloading code-aster (unrelated), due to an SSL certificate issue.

@erikscheurer
Copy link
Contributor Author

Building currently seems to fail at downloading code-aster (unrelated), due to an SSL certificate issue.

Is this something we can fix in this PR?

@MakisH
Copy link
Member

MakisH commented Oct 7, 2022

Building currently seems to fail at downloading code-aster (unrelated), due to an SSL certificate issue.

Is this something we can fix in this PR?

It is not related to this PR or anything from our side. I can work around this issue (insecurely), but I will give it some time, hoping for an upstream solution.

@MakisH
Copy link
Member

MakisH commented Nov 14, 2022

@erikscheurer can you please give me push access to your fork? You can enable this with a checkbox in the side of this PR.

@MakisH MakisH marked this pull request as draft November 14, 2022 11:39
@MakisH MakisH marked this pull request as ready for review November 14, 2022 11:39
@MakisH MakisH merged commit ecea39d into precice:develop Nov 15, 2022
MakisH added a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
MakisH added a commit that referenced this pull request Nov 18, 2022
Co-authored-by: Gerasimos Chourdakis <makishourdakis@gmail.com>
Co-authored-by: Ishaan Desai <ishaandesai@gmail.com>
Co-authored-by: Ishaan Desai <ishaan.desai@ipvs.uni-stuttgart.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants