-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Spatial Query Page #34
Open
nisarg210
wants to merge
10
commits into
feature/mission-selection-changes
Choose a base branch
from
feature/spatial-query-page
base: feature/mission-selection-changes
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Modify Spatial Query Page #34
nisarg210
wants to merge
10
commits into
feature/mission-selection-changes
from
feature/spatial-query-page
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nisarg210
commented
Nov 22, 2024
- Split Page in 30:70 ratio
- Modify Map height to fit entire screen.
- Added Side Block.
5 tasks
jinamshah
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I've uploaded the gif for spatial query demo
src/assets/gifs/spatial_query_eg.gif
- The left side and right side backgrounds are misaligned
- move the date selection lower - leaves a lot of space at the bottom
- box drawn on the spatial query page doesn't change orientation if the map is rotated
- users should not be allowed to draw multiple boxes on the map
- left and right sides need additional padding - refer to the figma design for context
++ needs rebase with base branch - https://github.com/precision-sustainable-ag/drone-image-manipulation/network |
akshat22
reviewed
Nov 26, 2024
akshat22
requested changes
Nov 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.