Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Spatial Query Page #34

Open
wants to merge 10 commits into
base: feature/mission-selection-changes
Choose a base branch
from

Conversation

nisarg210
Copy link
Collaborator

  • Split Page in 30:70 ratio
  • Modify Map height to fit entire screen.
  • Added Side Block.

@nisarg210 nisarg210 linked an issue Nov 22, 2024 that may be closed by this pull request
5 tasks
@nisarg210
Copy link
Collaborator Author

New Page After Modifications.
image

@jinamshah jinamshah self-requested a review November 25, 2024 17:53
Copy link
Collaborator

@jinamshah jinamshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I've uploaded the gif for spatial query demo src/assets/gifs/spatial_query_eg.gif
  • The left side and right side backgrounds are misaligned
    Screenshot 2024-11-25 at 1 28 49 PM
  • move the date selection lower - leaves a lot of space at the bottom
  • box drawn on the spatial query page doesn't change orientation if the map is rotated
  • users should not be allowed to draw multiple boxes on the map
  • left and right sides need additional padding - refer to the figma design for context

@jinamshah
Copy link
Collaborator

@akshat22 akshat22 self-requested a review November 26, 2024 10:54
src/assets/gifs/spatial_query_eg.gif Outdated Show resolved Hide resolved
src/pages/SpatialQuery/map.js Outdated Show resolved Hide resolved
@jinamshah
Copy link
Collaborator

jinamshah commented Nov 26, 2024

  • map draw box problem is still not fixed (see review above)
  • remove padding - 40-60 split looks fine with the video present
  • map gets cut by the footer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporal-Spatial Query Page Overhaul
3 participants