-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 delegate nan behavior to aggregators #294
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 96.42% 96.49% +0.07%
==========================================
Files 14 14
Lines 1146 1141 -5
==========================================
- Hits 1105 1101 -4
+ Misses 41 40 -1 ☔ View full report in Codecov by Sentry. |
Ready for review @jvdd! |
) | ||
|
||
# TODO -> integrate NANM4 (after the candlestick PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make an issue of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NaN support for M4 is still open
I added the issue, so this can be merged @jvdd? |
Removed the
check_nans
argument of the FigureResampler constructor and itsadd_traces
method. This argument was used to check for NaNs in the input data, but this is now handled by thenan_policy
argument of specific aggregators (see for instance the constructor of theMinMax
andMinMaxLTTB
aggregator).