Fix: Convert to numpy array before downsampling #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was attempting to use this with non-numpy arrays in a project https://github.com/jayceslesar/hyperplot and was having a small inconvenience where needed to convert to numpy arrays as that is an underlying assumption of this library - this should make that assumption more robust. Would also be interesting to integrate this into polars using the UDf/Pipe methodology but might want a separation of concerns there as this library does what it needs to really well and polars does what it needs to really well and ideally all the magic happens on the rust side of things anyways
Essentially this would fail:
with
And changing the line to
indices = LTTBDownsampler().downsample(np.array(df["timestamp"]), np.array(df["value"]), n_out=3)
was the fix