Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Polymer, if a property is defined as Boolean, then presence of that property in markup will lead to be treated as value true even if value is false, e.g.
<px-vis-axis id="xaxis" prevent-series-bar="false"></px-vis-axis> will still consider it as true.
This happens for same reason, if("false") console.log("true") will be logging "true" on console.
More details can be found here.
Polymer/polymer#1812
one of solution, which I think is minimum impact silver bullet, is to have such properties defined as Object rather than Boolean.
I have made this change for preventSeriesBar for px-vis-axis, as we use that in px-vis-xy-chart and our use case only has one series so not having series bar on y axis would be nice.
I hope this helps
Sandeep Khandewale
(Consultant, GE Oil and Gas, Mumbai)