refactor: default to ros-<distro>- prefixed names. #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #355
This PR inverts the logic of the default package name.
Assuming this
package.xml:This would make
ros_packagea conda dependency. We've decided that is not the right approach.This PR changes that assumption to
ros-<distro>-ros-packageand only if defined otherwise in thepackage_mapit will use the defined name in the map.ps. I adjusted the tests so they also run on macOS.