Skip to content

Conversation

@ruben-arts
Copy link
Contributor

Closes #355

This PR inverts the logic of the default package name.
Assuming this package.xml:

    <buildtool_depend>catkin</buildtool_depend>
    <depend>ros_package</depend>

This would make ros_package a conda dependency. We've decided that is not the right approach.
This PR changes that assumption to ros-<distro>-ros-package and only if defined otherwise in the package_map it will use the defined name in the map.

ps. I adjusted the tests so they also run on macOS.

@baszalmstra baszalmstra merged commit 6c94b5b into prefix-dev:main Sep 30, 2025
14 checks passed
@daenny daenny mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ROS: How to deal with the package naming of source build ros packages

2 participants