Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom exposed executable for global environments are no longer case sensitive #2478

Closed
2 tasks done
danielnachun opened this issue Nov 14, 2024 · 1 comment · Fixed by #2528
Closed
2 tasks done

Custom exposed executable for global environments are no longer case sensitive #2478

danielnachun opened this issue Nov 14, 2024 · 1 comment · Fixed by #2528
Labels
area:global Related to pixi global 🐞 bug Something isn't working

Comments

@danielnachun
Copy link

Checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example

In pixi 0.34, it was possible to use a command like this to get custom exposed executables R and Rscript for the r-base package

pixi global install r-base --export R=r --export Rscript=rscript

Issue description

Case sensitive exposed executable are an unfortunate necessity on Linux and Windows but not macOS. A key example is the executable names for r-base - on Linux and Windows, other programs trying to find R will always look for the R and Rscript and not r and rscript. This was previously possible but now with trampolines it seems that exposed executable names ignore the case. It would be great to have this back as it saves some manual "cleanup" afterward to rename the exposed executables or create symlinks.

Expected behavior

The exposed trampoline links/copies are still called r and rscript, but should be called R and Rscript.
@olivier-lacroix olivier-lacroix mentioned this issue Nov 19, 2024
Closed
2 tasks
@ruben-arts ruben-arts added area:global Related to pixi global 🐞 bug Something isn't working labels Nov 20, 2024
@ruben-arts
Copy link
Contributor

Thanks for the report, this sounds like a bug to me!

@wolfv wolfv mentioned this issue Nov 21, 2024
Merged
Hofer-Julian pushed a commit that referenced this issue Nov 21, 2024
@wolfv
fix: keep the case when getting the executable (#2528)
fd47c13 
For comparison purposes we were always lower-casing the executable name.
However, we also returned the lowercase version and exposed executables
as lowercase which doesn't match user expectations.

With this PR we are instead returning the original case. 

I cannot judge if this affects current exposed binaries. However, I
assume we would just keep the lower-case exposed binary as written in
the global manifest and only change newly installed tools.

fixes #2478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:global Related to pixi global 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: keep the case when getting the executable wolfv/pixi
2 participants
@danielnachun @ruben-arts