Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace _ with - when creating environments from features #1203

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Apr 16, 2024

I had a pyproject.toml that was using optional deps like:

[project.optional-dependencies]
test = ["pytest"]
conda_build = ["bla"]

Upon conversion, pixi complained because

  × failed to parse project manifest
    ╭─[pyproject.toml:26:1]
 25 │ default = { solve-group = "default" }
 26 │ conda_build = { features = ["conda_build"], solve-group = "default" }
    · ─────┬─────
    ·      ╰── Failed to parse environment name 'conda_build', please use only lowercase letters, numbers and dashes
 27 │ test = { features = ["test"], solve-group = "default" }
    ╰────

This fixes that issue.

@wolfv wolfv changed the title replace _ with - when creating environments from features fix: replace _ with - when creating environments from features Apr 16, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ruben-arts ruben-arts merged commit d0f372c into prefix-dev:main Apr 16, 2024
25 checks passed
@wolfv wolfv deleted the env-from-feature-dash branch April 16, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants