Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: For installing from a lock file without doing a solve beforehand #1460

Conversation

tdejager
Copy link
Contributor

Because of caching, the credentials were not available when a solve was
skipped. This makes sure the username and potentially password are
available for pulling from the registry.

More details are in this issue: #1374 (comment)

tdejager added 2 commits May 30, 2024 09:42
private pypi registries

Because of caching the credentials were not available when a solve was
skipped. This makes sure the username and potentially password are
available for pulling from the registry.
@ruben-arts
Copy link
Contributor

Nice find, how hard would it be to create a test for this?

@tdejager
Copy link
Contributor Author

Nice find, how hard would it be to create a test for this

First you need an external private registry if you want to rely on our own gcp instance being up,otherwise you need a proxy for pypi or something.
Second, a way to programatically clear the cache or ignore it?
Finally, a way to delete the .pixi folder.

I think that would be enough.

@ruben-arts
Copy link
Contributor

Do you think it's worth adding it now?

@tdejager
Copy link
Contributor Author

Do you think it's worth adding it now?

I'll try and make it :)

@tdejager
Copy link
Contributor Author

I'm thinking now it's somewhat hard to make a test because I need a global installation of keyring. This would make the test only runnable from a pixi env (with keyring) or when globally installed. So a cargo t without the global keyring installation would fail. At this point, I don't really think that's worth it for now :) wdyt @ruben-arts ?

@tdejager
Copy link
Contributor Author

Verification that it works for azure: #1374 (comment)

@ruben-arts ruben-arts merged commit 099116b into prefix-dev:main May 31, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants