-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump system requirements #1553
Conversation
I feel like instead of bumping the default minimum system requirements from time to time we should instead make the system requirements required for the relevant platforms. Then we bump the default system requirements of That way we only break once instead of small breaking changes for the rest of pixis life. |
I cant find the specific comment anymore but @ruben-arts proposed a method to dynamically determine system requirements when adding packages. We should also record the system requirements in the lock-file to eliminate future issues. |
I feel the problem happens more often for pypi dependencies these days, these typically have higher system requirements then conda dependencies. A solution for this would need to be found as well. Or we just go for @wolf or @Hofer-Julian ideas. |
Assuming we are somewhat confident that we can implement this, but don't plan to do so soon, I would propose to go for @wolfv's approach for now. It should improve the UX for most people in the short term. |
Agree |
What's our conclusion for now?
Or
I would even go for the first option and make the other changes later on. |
IMO we can merge this PR now. Record in the lockfile later, and then add rubens idea after that. |
Then let me insta update |
Since everyone seems in agreement I'll approve. |
In #1553, the system requirements were bumped, updated the docs to reflect this.
This PR bumps the system requirements to be more in line with current
manylinux2_28
and minimum macOS versions.While conda-forge is very conservative with the default system requirements, we can be a bit more bold. We based our first set of defaults on
conda-forge
defaults, but the aims are somewhat different: conda-forge tries to build packages for maximum compatibility while we are developing a software that is modern and probably mostly used on recent machines.There is some pain with wheels that are only available for macOS 13.0+ which have become somewhat common on PyPI. Users would then receive
sdists
with all of their problems. Therefore I think it would be good to bump the minimum here. Users that want to support older systems or RedHat style Linux versions can always set different values in thepixi.toml
.