Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the fish completions location #1647

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

tdejager
Copy link
Contributor

Output to the completions directory, this seems more of the fishy way, AFAIK.

@tdejager tdejager requested a review from ruben-arts July 22, 2024 08:18
docs/index.md Outdated
@@ -78,7 +78,7 @@ Add-Content -Path $PROFILE -Value '(& pixi completion --shell powershell) | Out-
### Fish

```fish
echo 'pixi completion --shell fish | source' >> ~/.config/fish/config.fish
pixi completion --shell > ~/.config/fish/completions/pixi.fish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thing to note - this changes the completions to be "non-dynamic", right?
ie. someoen might have to update their completions file after a pixi release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm you are right. Let me test something.

docs/index.md Outdated Show resolved Hide resolved
@tdejager tdejager changed the title doc: improve the fish completions location docs: improve the fish completions location Jul 22, 2024
@Hofer-Julian
Copy link
Contributor

For context, this is what starship does, where I also copied nushell from: https://starship.rs/#fish

@tdejager
Copy link
Contributor Author

For context, this is what starship does, where I also copied nushell from: starship.rs/#fish

Sure, but I don't really like cluttering the main fish script, thats what the completions or even the conf directory is for.

@Hofer-Julian
Copy link
Contributor

For context, this is what starship does, where I also copied nushell from: starship.rs/#fish

Sure, but I don't really like cluttering the main fish script, thats what the completions or even the conf directory is for.

I trust you on that, just wanted to add a data point :)

@ruben-arts ruben-arts merged commit cb1f039 into prefix-dev:main Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants