Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract pixi_manifest #1656

Merged
merged 5 commits into from
Jul 23, 2024
Merged

refactor: extract pixi_manifest #1656

merged 5 commits into from
Jul 23, 2024

Conversation

baszalmstra
Copy link
Contributor

This is a big refactor that moves the project::manifest module into a separate crate. This allows us to reuse it in other places.

@baszalmstra baszalmstra force-pushed the refactor/extract_manifest branch from 7bf7bef to 5c13623 Compare July 23, 2024 11:32
@baszalmstra baszalmstra marked this pull request as ready for review July 23, 2024 11:42
@baszalmstra baszalmstra requested a review from ruben-arts July 23, 2024 13:07
ruben-arts
ruben-arts approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 145 files, LGTM :shipit:

@ruben-arts ruben-arts merged commit c963a41 into prefix-dev:main Jul 23, 2024
24 checks passed
@ruben-arts ruben-arts mentioned this pull request Jul 23, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruben-arts ruben-arts ruben-arts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baszalmstra @ruben-arts @tdejager