fix: fix and refactor --no-lockfile-update
#1683
Conversation
|
Conflicts are for after the weekend when the mind is fresh |
src/cli/remove.rs
Outdated
| @@ -58,13 +66,13 @@ pub async fn execute(args: Args) -> miette::Result<()> { | |||
| // updating prefix after removing from toml | |||
| get_up_to_date_prefix( | |||
There was a problem hiding this comment.
Shouldn't this be entirely skipped when --no-lockfile-update is used? I don't think it's a no-op currently
There was a problem hiding this comment.
Otherwise, I am not sure #1669 will actually be fixed?
There was a problem hiding this comment.
I added this, but it doesn't really matter for the logic. But just to be sure I can agree ;)
pixi.toml
Outdated
| @@ -95,3 +95,6 @@ lint = { features = [ | |||
| schema = { features = [ | |||
| "schema", | |||
| ], no-default-feature = true, solve-group = "default" } | |||
|
|
|||
| [dependencies] | |||
| boltons = ">=24.0.0,<25" | |||
| /// Don't install the environment for pypi solving, only update the lock-file if it can solve without installing. | ||
| #[arg(long)] | ||
| pub no_install: bool, | ||
| pub prefix_update_config: PrefixUpdateConfig, |
There was a problem hiding this comment.
This removes the --frozen and --locked.
@baszalmstra , do you mean the entire concept or the name of the feature? I feel having the ability to defer lockfile update after a series of operations on the manifest is useful. Pixi solve is fast, but not as fast as no solve at all :-) |
|
@olivier-lacroix I think what bas means is that we don't have the |
|
@baszalmstra @ruben-arts , I do not see these are equivalent. But maybe I misunderstand something? see #1669 (comment) |
|
@baszalmstra This PR does not yet remove the |
Fixes #1669
Refactors the cli configuration into:
ProjectConfig: just the manifest path for now but resusing the cli fieldPrefixUpdateConfig: All settings related to the update of the prefix and lockfileDependencyConfig: All the settings to specify what type of dependency you want to interact with.