Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Let pixi init create hatchling pyproject.toml #1693

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

Hofer-Julian
Copy link
Contributor

No description provided.

@ruben-arts
Copy link
Contributor

Could you update the documentation: https://pixi.sh/latest/advanced/pyproject_toml/#build-system-section

Including a short mention of the decision to use hatchling and providing a link to their documentation.

@Hofer-Julian
Copy link
Contributor Author

Could you update the documentation: https://pixi.sh/latest/advanced/pyproject_toml/#build-system-section

Including a short mention of the decision to use hatchling and providing a link to their documentation.

I've committed that on main by accident :/
bb65e3f

@ruben-arts
Copy link
Contributor

@Hofer-Julian Don't worry this will go in soon.

Any idea why the test are still failing? Is the dependencies use the wrong version of setuptools themselfs?

@Hofer-Julian
Copy link
Contributor Author

Any idea why the test are still failing? Is the dependencies use the wrong version of setuptools themselfs?

The tests are not using pixi init --pyproject unfortunately but plain pixi init.
They will have to be fixed differently.

@olivier-lacroix
Copy link
Contributor

olivier-lacroix commented Jul 29, 2024

Numerous python tests will fail because of this : pypa/setuptools#4519

Happy Monday :-)

@olivier-lacroix
Copy link
Contributor

@Hofer-Julian maybe you will want to adjust the *.egg-info from the GITIGNORE_TEMPLATE, which is (I think?) specific to setup-tools?

@Hofer-Julian
Copy link
Contributor Author

@Hofer-Julian maybe you will want to adjust the *.egg-info from the GITIGNORE_TEMPLATE, which is (I think?) specific to setup-tools?

Could you please double-check if egg-info are indeed not a thing with hatchling?
If yes, I agree that this line can be removed.

@olivier-lacroix
Copy link
Contributor

Will do. This can be adapted in a follow up PR though. No need to hold off on my account 🙂

@tdejager
Copy link
Contributor

@Hofer-Julian maybe you will want to adjust the *.egg-info from the GITIGNORE_TEMPLATE, which is (I think?) specific to setup-tools?

Could you please double-check if egg-info are indeed not a thing with hatchling? If yes, I agree that this line can be removed.

I'm about 80% certain that with default configurations, hatchling does not create the egg-info artificats (which in and of themselves are not exclusive to setuptools).

@tdejager
Copy link
Contributor

We've decided to keep in in for now @olivier-lacroix :)

@tdejager tdejager enabled auto-merge (squash) July 30, 2024 09:20
@tdejager tdejager merged commit 300d982 into prefix-dev:main Jul 30, 2024
24 checks passed
@zbowling
Copy link

causing a bit of a regression: #1941

@Hofer-Julian Hofer-Julian deleted the build/init-hatchling branch August 30, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants