Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move, splits and renames the HasFeatures trait #1717

Merged
merged 1 commit into from
Aug 1, 2024
Merged

refactor: move, splits and renames the HasFeatures trait #1717

merged 1 commit into from
Aug 1, 2024

Conversation

tdejager
Copy link
Contributor

@tdejager tdejager commented Aug 1, 2024

Refactor and move the HasFeatures trait.

  1. I've renamed the HasFeatures into FeaturesExt, don't know of a better name.
  2. Also split into the two different providers needed for FeaturesExt, and made a blanket implementation for it.
  3. I renamed the lifetime paremeter to 'source to imply that the features have a source of truth that they originate from. But in the implementations I've kept the 'p to imply that its from the Project.

@tdejager tdejager requested a review from baszalmstra August 1, 2024 12:40
@tdejager tdejager enabled auto-merge (squash) August 1, 2024 13:05
@tdejager tdejager merged commit dd094f0 into prefix-dev:main Aug 1, 2024
24 checks passed
@ruben-arts ruben-arts mentioned this pull request Aug 5, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdejager @baszalmstra