Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to increase rlimit #1766

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

baszalmstra
Copy link
Contributor

This is an attempt to fix #1551

This PR does two things:

  • Concurrent prefix installations share the same io concurrency limit to ensure we dont open too many files when running multiple installations concurrently.
  • Pixi attempts to increase the soft rlimit to a "more sensible" value of 1024.

@wolfv, @ruben-arts Would you be able to test this PR locally. I added a bunch of tracing to the rlimit setting. I wonder what happens on your machine.

@baszalmstra baszalmstra requested review from ruben-arts and wolfv August 8, 2024 09:00
@ruben-arts
Copy link
Contributor

If I set the ulimit to 100 manually It tells me that it tried to overwrite it:

> ulimit -n 100

> pixi install
...
 INFO pixi::rlimit: Attempted to set RLIMIT_NOFILE to 1024 but was only able to set it to 100
...

Not sure if that would be expected but it at least keeps working for me.

@baszalmstra
Copy link
Contributor Author

Mm since Im a Windows kinda guy Im not entirely sure how this is supposed to work. @wolfv Maybe you can help me out here.

Do you always see that info statement @ruben-arts ? Or did you have to use -v? It should not appear if you dont use -v.

@wolfv
Copy link
Member

wolfv commented Aug 9, 2024

let me try with the large environment once again! :)

@wolfv
Copy link
Member

wolfv commented Aug 10, 2024

Looks good! Old pixi version was consistently failing on ros2-nav2, but the build of this PR works like a charm! :)

Screenshot 2024-08-10 at 18 43 29

@baszalmstra
Copy link
Contributor Author

If you run the command with -v does it also tell you something about the rlimit?

@wolfv
Copy link
Member

wolfv commented Aug 10, 2024

Yes! Similar to Ruben I got something like CB 1024

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be fine for me

@ruben-arts ruben-arts merged commit 30bf94c into prefix-dev:main Aug 12, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many open files
3 participants