-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: using file url as mapping #1930
Merged
ruben-arts
merged 10 commits into
prefix-dev:main
from
nichmor:fix/using-file-url-as-mapping
Sep 2, 2024
Merged
fix: using file url as mapping #1930
ruben-arts
merged 10 commits into
prefix-dev:main
from
nichmor:fix/using-file-url-as-mapping
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
reviewed
Aug 28, 2024
@@ -45,6 +47,21 @@ where | |||
Ok(mapping_by_name) | |||
} | |||
|
|||
pub fn fetch_mapping_from_path<T: DeserializeOwned, P: AsRef<Path>>(path: &P) -> miette::Result<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the name of the function I would expect this to return a mapping but instead it returns anything that is deserializable. Imo we can just remove the generics.
baszalmstra
approved these changes
Aug 28, 2024
@nichmor Can you fix the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported by our user : https://discord.com/channels/1082332781146800168/1276948298330275922/1276948298330275922
when using this mapping setup :
pixi will error out because we don't understand file url scheme.
This PR aims to fix it.