Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always overwrite when pixi adding the dependency #1935

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: always overwrite when pixi adding the dependency #1935

merged 2 commits into from
Aug 30, 2024

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Aug 28, 2024 •
edited
Loading

Before:

pixi add numpy
pixi add pandas==2.0.1
# fails because of numpy <2 requirement
pixi add numpy panda==2.0.1
# Still fails but it should just resolve the two packages together

After this PR

pixi add numpy
pixi add pandas==2.0.1
# fails because of numpy <2 requirement
pixi add numpy panda==2.0.1
# Works as numpy is readded to the project without constraints and the solve is rerun for it.

@ruben-arts ruben-arts requested a review from baszalmstra August 28, 2024 13:10
@tdejager tdejager changed the title fix: overwrite always when pixi adding the dependency fix: always overwrite when pixi adding the dependency Aug 30, 2024
@tdejager tdejager merged commit 3f5f965 into prefix-dev:main Aug 30, 2024
28 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Sep 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruben-arts @baszalmstra @tdejager