Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add back older caching method #2046

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

tdejager
Copy link
Contributor

@tdejager tdejager commented Sep 13, 2024

Add back older caching method, at it seems to work much better for uv.

channels(1)

I think github caching got a lot faster again, caching downloding for uv takes about a minute but the runs speed up considerably. So why this seems so much faster I don't really know, when its in I'll add lines to only save the cache in main builds from another PR.

We could also start using buildjet: https://github.com/Swatinem/rust-cache/blob/master/.github/workflows/buildjet.yml that gives us a 20G limit instead of 10G.

Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side.
My only question is : do you know why this approach works better than sccache?

.github/workflows/rust.yml Outdated Show resolved Hide resolved
@baszalmstra baszalmstra merged commit f2d4ce0 into prefix-dev:main Sep 13, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants