feat: add --priority arg to project channel add
#2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allows specifying priority - fixes `channel remove` when priority is present in channels
minrk
force-pushed
the
add-channel-priority
branch
from
186dca0 to
d7ed6b4
Compare
minrk
changed the title
project channel addproject channel add
always recreate the list rather than parse, edit, unparse
ruben-arts
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Thanks you!
This looks good. I would like to move the serialization code to the PrioritizedChannel code.
Also could you add some tests to verify that the channel priority is correctly added. This can be done in the pixi_manifest/src/manifests/manifest.rs. There should be some tests you could mimic.
Comment on lines
574
to
577
| let mut table = Table::new().into_inline_table(); | ||
| table.insert("channel", channel.channel.to_string().into()); | ||
| table.insert("priority", i64::from(priority).into()); | ||
| push(table.into()); |
There was a problem hiding this comment.
Instead of you could implement the toml_edit::Value for this PrioritizedChannel. Which then might be reused in different places.
minrk
force-pushed
the
add-channel-priority
branch
from
6b86e1c to
d531eb3
Compare
|
Moved the serialization, did my best to add tests. There didn't appear to be any tests for |
ruben-arts
approved these changes
Sep 23, 2024
|
Test fail because of a non related issue! |
|
Thanks for merging and thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project channel removewhen priority is present in channels, which errored before.Draft because this is my first ever Rust PR, and I assume there must be a better way to turn a toml Value into a PrioritizedChannel than what I've done here. I'd love a pointer for the right way to do Value->PrioritizedChannel.
closes #2035