-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if files are same in self-update
#2132
Conversation
self-update
self-update
Thank you this looks good to me! What makes this a Draft PR? |
Draft PR because I just wanted to run the CI! I haven't yet manually tested it for the case in #1171 . |
Okay did some testing. I think this implies the fix in my PR works! When I use (the official)
But when I do
(This error does not occur when I use e.g. When I run I have no idea why there is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @apoorvkh !
self-update
checks if the Pixi binary matches the default filepath. Instead of checking if paths are equal, we should check if files are same inself-update
.This should resolve this issue:
which could be caused by using symlinks or case-insensitivity in Windows, etc.
Fixes #1171 and maybe #2059