fix task cache recursion into .pixi folder #2205
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@0xbe7a this is an attempt to fix the issue that broken symlinks are currently tripping up the task cache.
However I looked at your original PR and if I understand correctly you want to explicitly look inside the
.pixi
folder for some files to be cached, correct?The usage of the whole
ignore
crate is unfortunately a little cumbersome because we usually want/expect the inverse logic where our rules are supposed to only recurse into folders that are selected by some globs and not search through everything as is currently done. I need to look into how that could be supported.Besides, we can catch the error and skip over broken symlinks in the
Err(e)
branch of the walker.