Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix task cache recursion into .pixi folder #2205

Closed
wants to merge 2 commits into from

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Oct 5, 2024

@0xbe7a this is an attempt to fix the issue that broken symlinks are currently tripping up the task cache.

However I looked at your original PR and if I understand correctly you want to explicitly look inside the .pixi folder for some files to be cached, correct?

The usage of the whole ignore crate is unfortunately a little cumbersome because we usually want/expect the inverse logic where our rules are supposed to only recurse into folders that are selected by some globs and not search through everything as is currently done. I need to look into how that could be supported.

Besides, we can catch the error and skip over broken symlinks in the Err(e) branch of the walker.

@wolfv
Copy link
Member Author

wolfv commented Oct 5, 2024

I pushed additional changes that ignore any broken symlink. I think we should either make a decision really quickly or revert the follow_symlinks change and rethink how we go about this.

@0xbe7a
Copy link
Contributor

0xbe7a commented Oct 5, 2024

In the end, I found that using a PyPI dependency instead of a post-install task worked great, so I’m fine with reverting the change for now.

Hofer-Julian pushed a commit that referenced this pull request Oct 7, 2024
Unfortunately the `.follow_links(true)` created some issues. The idea is
to completely redo the file search logic but for now we turn of the
breaking option.

Closes #2196 #2205
@ruben-arts ruben-arts closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants