fix: parse env name on adding #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw tried to add a poper test but there was no framework to properly do that yet. Will have to improve that, but the |
src/cli/project/environment/add.rs
Outdated
| @@ -26,7 +27,7 @@ pub struct Args { | |||
|
|
|||
| pub async fn execute(mut project: Project, args: Args) -> miette::Result<()> { | |||
| let environment_exists = project | |||
| .environment(&EnvironmentName::Named(args.name.clone())) | |||
| .environment(&EnvironmentName::from_str(args.name.as_str())?) | |||
There was a problem hiding this comment.
Could you change the type of args.name to EnvironmentName like we do with pixi global?
There was a problem hiding this comment.
Applied my suggestion in af2bc1f
Hofer-Julian
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2245
Now parses the environment name