-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add pybind11 example #2324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
The build took 3 minutes on my machine, which feels a bit long for 10 lines of C++ code. I haven't used pybind11 before, so I don't know if that is normal.
@Hofer-Julian I'm not sure why that is. I think it's mainly due to |
Maybe someone with more C++ experience like @baszalmstra or @wolfv could check it out as well |
~17s with the
|
Sounds to me like we should pass the |
Yeah, generally you'd like |
@Hofer-Julian fixed it. The sdist was including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Let's bring it in then!
Hi! Just saw this PR. It's a nice example. I wanted to mention that we also use
You might find that useful. See https://gitlab.com/tango-controls/pytango/-/blob/develop/pixi.toml?ref_type=heads#L18 |
This is an example of using Pixi to compile pybind11 modules and make them available to any Python interpreter.
scikit-build-core
is the tool used in the example to generate the.whl
files.