feat: Adding SCM option for init command #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvgaona
changed the title
|
I tested in the 3 SCMs here and works just fine. Let me know if unit tests would be needed for this. |
ruben-arts
reviewed
Oct 25, 2024
|
Added the use of |
|
@ruben-arts would you also like to ignore case in |
Yes please! |
alvgaona
commented
Oct 25, 2024
| } | ||
|
|
||
| #[test] | ||
| fn test_invalid_scm_values() { |
There was a problem hiding this comment.
Not sure how much value this test adds but it doesn't hurt to have an extra test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for my boldness. I sometimes work with multiple SCMs and found that this command lacked this feature. Let me know if it's aligned with the project. Feel free to close this PR, otherwise. 😄