Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use built in string methods #2348

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

KGrewal1
Copy link
Contributor

For quote escaping strings, use built in contains method to find presence of special characters, and put characters directly into (pre allocated) String, instead of vector of bytes, that is then cast into a string.

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@ruben-arts ruben-arts merged commit 5a3ae2c into prefix-dev:main Oct 25, 2024
40 checks passed
@KGrewal1 KGrewal1 deleted the quote-escaping branch October 25, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants