-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trampoline for pixi global #2381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I took a few shortcuts but this is a prototype of the trampoline. upd @nichmor : no more a prototype :D things on how to test this: - [ ] verify that it correctly migrates a global installed binary from .sh/.bat to trampoline. this can be done by following: using previous `pixi`: `pixi global install python` and then ` cargo run -- global install python`. `python` should be in a working state, and by looking into `cat /Users/graf/.pixi/bin/python` you should see that is a binary code , not a script anymore - [ ] using following code, and when running it with global installed python and pressing CTRL-C you should see `CTRL-C caught! Successful termination.` <details> ``` import signal import time def signal_handler(sig, frame): print("\nCTRL-C caught! Successful termination.") exit(0) # Register the signal handler for SIGINT (CTRL-C) signal.signal(signal.SIGINT, signal_handler) print("Press CTRL-C to stop the script.") # Simulating some work with an infinite loop try: while True: time.sleep(1) # Keeps the script running except KeyboardInterrupt: # You can also handle it here, but we already have the signal handler pass ``` </details> - [ ] test if `pixi global install` behave correctly in different shells --------- Co-authored-by: nichmor <nmorkotilo@gmail.com> Co-authored-by: Julian Hofer <julianhofer@gnome.org> Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com> Co-authored-by: Ruben Arts <ruben.arts@hotmail.com>
to reiterate missing things:
|
This reverts commit 65fe2d7.
Testing:Preparation
Things we should test:
|
Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
Here are a few things I tried:
|
ruben-arts
approved these changes
Nov 5, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: