Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update ros2.md turtlesim section #2442

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

nbbrooks
Copy link
Contributor

@nbbrooks nbbrooks commented Nov 9, 2024

Great quick start - here a couple small suggestions from a fresh set of eyes!

Also, the turtlesim image link is broken. I can add this image

turtlesim

to fix it - where in the repo should such an asset be stored?

Improve docs clarity for turtlesim keyboard control and manifest activation section.
@ruben-arts
Copy link
Contributor

Thanks for helping to improve it!

Since you uploaded the image in this pr you should have a gitub url that you can paste into the markdown directly.

docs/tutorials/ros2.md Outdated Show resolved Hide resolved
@nbbrooks nbbrooks changed the title Update ros2.md turtlesim section docs: Update ros2.md turtlesim section Nov 12, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ruben-arts ruben-arts merged commit 3611dae into prefix-dev:main Nov 13, 2024
5 of 6 checks passed
tdejager pushed a commit to tdejager/pixi that referenced this pull request Nov 15, 2024
@nbbrooks nbbrooks deleted the patch-1 branch November 18, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants