-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build recipe yaml directly #2568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some linting errors!
For sure, but maybe you guys can check if this is going in the right direction :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would still need a proper error if pixi build
is called on a toml without a build-section and no recipe.yaml. Or maybe I missed this.
crates/pixi_build_frontend/src/protocols/builders/rattler_build.rs
Outdated
Show resolved
Hide resolved
crates/pixi_build_frontend/src/protocols/builders/rattler_build.rs
Outdated
Show resolved
Hide resolved
Seems like a useful default for sure! |
crates/pixi_build_frontend/src/protocols/builders/rattler_build.rs
Outdated
Show resolved
Hide resolved
looks like a reasonable direction to me! |
I cleaned up my changes, and just discussed the requirement for So this should go away, but IMO that is a follow up PR we should do. I would argue we can merge this as is now, and then iterate further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good !
boring request: could we add a smoke test for this in integration_python/test_build.py?
crates/pixi_build_frontend/src/protocols/builders/rattler_build.rs
Outdated
Show resolved
Hide resolved
crates/pixi_build_frontend/src/protocols/builders/rattler_build.rs
Outdated
Show resolved
Hide resolved
Let's add a proper test once the |
e59f1fd
to
551a8ac
Compare
This adds some "fallback" behavior if a recipe.yaml is found but no
pixi.toml
next to it.We just default to the
pixi-build-rattler-build
backend.I am currently testing with:
and a
recipe.yaml
that looks like: