fix: always show cursor after control+c #2635
Conversation
|
I remember we explicitly removed ctrl+c handler at some point. @tdejager do you remember why? |
|
We explicitly removed the CTRL+C handler in the |
|
Also you can use |
… it and the gnu version is not guaranteed to work.
…rget for it and the gnu version is not guaranteed to work." This reverts commit b47ee5c.
src/cli/run.rs
Outdated
| @@ -326,6 +326,14 @@ fn disambiguate_task_interactive<'p>( | |||
| ..ColorfulTheme::default() | |||
| }; | |||
|
|
|||
| // Ignore CTRL+C in the dialoguer prompt so that it shows the cursor again. | |||
| ctrlc::set_handler(move || { | |||
There was a problem hiding this comment.
I am still in favor of using tokio if we can make it work :)
|
I notice one weird thing with this change. It seems to work like I would expect when killing things run after this command. But canceling an install acts differently from cancelling a normal install: This is repeatable for some reason, @wolfv or @baszalmstra would you know why that could happen? e.g. did I just introduce a terrible bug that my testing isn't verifying? |
|
This is what the docs say. I wonder if we're in this situation - and need to come up with our own way of killing the remaining threads. 
|
fixes #1548 #2625
The issue is related to and fixed with help of console-rs/dialoguer#77