feat: add cli modifications of the system requirements #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hofer-Julian
requested changes
Dec 30, 2024
There was a problem hiding this comment.
This looks like a useful addition @ruben-arts!
Apart from my comments, I would also like to see an integration test, testing the CLI
Comment on lines
51
to
60
| let (version, family) = args | ||
| .version | ||
| .split_once(' ') | ||
| .ok_or_else(|| { | ||
| miette::miette!("Invalid version and family string. Expected format: <version> <family>, e.g. '2.17 libc'") | ||
| })?; | ||
|
|
||
| let version = version.parse().into_diagnostic().wrap_err( | ||
| "Invalid version string, expected format: <version> <family>, e.g. '2.17 libc'", | ||
| )?; |
There was a problem hiding this comment.
By shifting this logic to clap, --help and completions will be much more useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We want to work towards more automation around the system requirements. Most likely, a part of that is automated serialization for the manifest. This is a preparation for that. And secondly, it's better to have CLI options for DX and especially for tutorial.
Feature
Allows users to run:
TODO:
system-requirements remove: Not in this prsystem-requirements list