-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a progress bar for source ( git ) dependencies #2898
feat: add a progress bar for source ( git ) dependencies #2898
Conversation
…nto feat/add-git-progress-bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reporter that you pass in now is very specific to git. In the future when we also fetch source archives via URLs we might want something similar.
I also think we might want to have a reporter per clone instead of one progress bar for all the git clones?
The reporter also doesnt actually report any progress other than start and finish. Is there not a way to get more fain grained progress?
I sticked to the same trait definition as uv ( having only on checkout _start and _finish ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and I like the output!
I've not touched the progress bars myself so maybe good to let @baszalmstra review this technically.
Co-authored-by: Bas Zalmstra <zalmstra.bas@gmail.com>
Overview
Adding progress bar for source ( git ) operations.
This is how it looks when solving metadata for source dependencies.
new-git-pb.mov
How to test it?
You can add these git dependencies in our
examples/pixi-build/cpp-sdl/pixi.toml
[dependencies]
and run
pixi install
.If you want to take a look again, please remove cache, git cache, and
pixi.lock
so retrieving metadata will start again.