fix: unify reqwest Client for self_update when downloading archives #3346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzm55
force-pushed
the
work/reqwest-self-update
branch
2 times, most recently
from
f8ce0c7 to
26d6c72
Compare
gzm55
force-pushed
the
work/reqwest-self-update
branch
from
26d6c72 to
586abe3
Compare
gzm55
force-pushed
the
work/reqwest-self-update
branch
from
586abe3 to
ab44506
Compare
Contributor
|
Sorry for the delay! I feel uncomfortable reviewing this code, and I'd rather leave that to @ruben-arts. He is currently on a holiday and will be back next week! |
Contributor
Author
|
@ruben-arts any suggestion about this pr? |
ruben-arts
reviewed
May 12, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
If you split the PR into two where one adds the reqwest handler it might be easier to review and merge them.
Sorry for the late response, it got lost in my notifications.
Contributor
Author
ok i will split this pr |
Contributor
Author
|
@ruben-arts the |
Contributor
Author
|
@ruben-arts @baszalmstra any suggestion about the current patch? |
ruben-arts
approved these changes
May 28, 2025
Contributor
ruben-arts
left a comment
ruben-arts
left a comment
There was a problem hiding this comment.
Sorry for the long wait, this work great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwest_client_builderfunction, the proxies config is applied here.self_updatesubcommand download the pixi pre-built binary archives with project unified reqwest Client.self_updatebuild reqwest Client with a builder fromreqwest_client_builder