Skip to content

Conversation

@tdejager
Copy link
Contributor

@tdejager tdejager commented Jan 2, 2026

Replace fish_add_path with set -gx PATH for compatibility with Fish versions older than 3.2.0 (e.g., Fish 3.1.0 on Ubuntu 20.04).

This is consistent with how bash/zsh PATH setup is handled in the same script.

Description

Fixes #5210

How Has This Been Tested?

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Sonnet

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

Replace `fish_add_path` with `set -gx PATH` for compatibility with
Fish versions older than 3.2.0 (e.g., Fish 3.1.0 on Ubuntu 20.04).

This is consistent with how bash/zsh PATH setup is handled in the
same script.

Fixes #5210
@tdejager
Copy link
Contributor Author

tdejager commented Jan 2, 2026

@melonedo can you give this a go?

@tdejager tdejager changed the title Fix issue 5210 fix: issue 5210 Jan 2, 2026
@tdejager tdejager requested a review from ruben-arts January 2, 2026 08:27
@nichmor nichmor changed the title fix: issue 5210 fix: fish shell integration is broken on older version of fish Jan 2, 2026
@melonedo
Copy link

melonedo commented Jan 2, 2026

It should work if I modify ~/.config/fish/config.fish as in the commit, but I am new to pixi so I am not sure how to test the install script itself.

Copy link
Contributor Author

tdejager commented Jan 2, 2026

I think uninstall and reinstalling from the script 🙂

@melonedo
Copy link

melonedo commented Jan 2, 2026

I think uninstall and reinstalling from the script 🙂

I am sorry, but doesn't install/install.sh download from GitHub releases instead of instead of installing from a local file?

@lucascolley lucascolley added bug Something isn't working cli Issue related to CLI labels Jan 4, 2026
@tdejager
Copy link
Contributor Author

tdejager commented Jan 6, 2026

That does not really matter right? As long as you clone the repository locally and then test the script directly?

@melonedo
Copy link

melonedo commented Jan 6, 2026

That does not really matter right? As long as you clone the repository locally and then test the script directly?

Yes, AFAICT it works.

@ruben-arts ruben-arts enabled auto-merge (squash) January 6, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli Issue related to CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fish shell integration is broken on older version of fish

6 participants