-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Working towards self-update
#582
Conversation
Nice that you are working on this :)! Like you said in the comment, I've had problems with this in the past where I've used the command to update a If we want to include it, I think we could add the check like you said, or maybe add a feature to not compile it in. So put it behind a feature flag. Wdyt @baszalmstra and @ruben-arts ? |
Well, if you can still force it, then it would still be a risk. That's why I think putting it behind a (maybe default) feature would be nice :) that way the package manager maintainers have the guarantee it will not happen. |
Yeah thats a good idea, but it would mean the package managers always have to build from source to disable the feature. |
Which a lot of them do, or have seperate release for it |
What is the status of this PR? |
dormant but not dead! :) |
Are you guys ok if I try to wrap up that feature in a separate PR but based on this branch?
On that topic, I feel it's best to add the logic within the code itself by checking the location of the binary (versus behind a feature) so packager folks don't have to know or remember this particular point when building pixi and everything is self-contained. But happy to follow what you guys think is best. |
@hadim if you take over this PR, that would be great! I am pretty busy with |
--force
option to allow overwriting in other locations.