-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): new pixi global list
display format
#723
Conversation
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
pixi global list
display format
It already looks good but the tree view makes it a look like this is the structure of the folder. Which is not really true.
Please give it your own twirl, it shouln't become a disco but I think it could be easier on the eyes. A future idea could be to color the version based on how outdated it is. (green = latest, yellow = minor version difference, red = major version difference) |
He @chawyehsu, would you want to continue the work on this PR? |
@ruben-arts Yes but I may be slow on this at the moment. Will make some time on trying to get it accpeted before next weekend. The aforementioned format looks good to me, I will update the PR to use it. However, there may be predictable line wrap breaking the format when listing binaries in a line if there are many bins or names of bins are longer than terminal width. I don't know if it should be compromised. Suggested colors output sounds good, too. Coloring version based on how outdated it is may require another network querying? Will try but may not in this branch if the complexity is high. |
Thanks @chawyehsu Good though on the line wrap, I think it should be okay for now. I think its better to leave the outdated feature out for now to get this pr in sooner. |
Signed-off-by: Chawye Hsu <su+git@chawyehsu.com>
I just pushed the updated format, this is how it currently looks like:
After a few tries, I found instead of coloring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works very nice! left a few small nitpicks but already in a mergable state! Thanks you
Co-authored-by: Ruben Arts <ruben@prefix.dev>
Implement #708 (comment) Close #708
example output