Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tcsh install support #898

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

obust
Copy link
Contributor

@obust obust commented Mar 1, 2024

This addresses #897

Before

case supported shell: bash

$ echo $SHELL
/bin/bash

$ bash ./install/install.sh
This script will automatically download and install Pixi (latest) for you.
Getting it from this url: https://github.com/prefix-dev/pixi/releases/latest/download/pixi-aarch64-apple-darwin.tar.gz
The binary will be installed into '/Users/romain/.pixi/bin'
######################################################################## 100.0%
Updating '/Users/romain/.bash_profile'
Please restart or source your shell.

case unsupported shell: tcsh

$ echo $SHELL
/bin/tcsh

$ bash ./install/install.sh
This script will automatically download and install Pixi (latest) for you.
Getting it from this url: https://github.com/prefix-dev/pixi/releases/latest/download/pixi-aarch64-apple-darwin.tar.gz
The binary will be installed into '/Users/romain/.pixi/bin'
######################################################################## 100.0%
Unsupported shell: bash
Please restart or source your shell.

Now

case supported shell: tcsh

$ echo $SHELL
/bin/tcsh

$ bash ./install/install.sh
This script will automatically download and install Pixi (latest) for you.
Getting it from this url: https://github.com/prefix-dev/pixi/releases/latest/download/pixi-aarch64-apple-darwin.tar.gz
######################################################################### 100.0%
The 'pixi' binary is installed into '/Users/romain/.pixi/bin'
Updating '/Users/romain/.tcshrc'
Please restart or source your shell.

See references:

case unsupported shell: ksh

$ echo $SHELL
/bin/ksh

$ bash ./install/install.sh
This script will automatically download and install Pixi (latest) for you.
Getting it from this url: https://github.com/prefix-dev/pixi/releases/latest/download/pixi-aarch64-apple-darwin.tar.gz
######################################################################### 100.0%
The 'pixi' binary is installed into '/Users/romain/.pixi/bin'
Could not update shell: ksh
Please permanently add '/Users/romain/.pixi/bin' to your $PATH to enable the 'pixi' command.

I believe the error message is clearer and the user can proceed on their own to enable pixi. See issue #897 for more explanations own why I find the previous error confusing/misguiding.

@obust obust changed the title 897 add tcsh install support feat: add tcsh install support Mar 1, 2024
@wolfv
Copy link
Member

wolfv commented Mar 2, 2024

Thanks! This looks good to me 👍

@ruben-arts ruben-arts merged commit 83fd070 into prefix-dev:main Mar 4, 2024
16 checks passed
@ruben-arts
Copy link
Contributor

Thanks @obust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants