-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement inputs
and outputs
hash based task skipping
#933
Conversation
inputs
and outputs
hash based task skipping
inputs
and outputs
hash based task skipping inputs
and outputs
hash based task skipping
92bf1f5
to
46ae4d5
Compare
One thing I noted is that "globbing" folders doesn't work (e.g. |
What doesn't work for me in the
|
I fixed that issue - we were taking into account any |
We now store the task cache under Things we should consider:
Maybe we should spend a few minutes thinking about these items, but IMO it's good to merge now. |
This doesn't work yet. I tried adding It will error on not having the Edit: This works now but only with |
Co-authored-by: Bas Zalmstra <bas@prefix.dev>
src/task/task_hash.rs
Outdated
}; | ||
|
||
let files = | ||
FileHashes::from_files(&task.working_directory().unwrap(), inputs.iter()).await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will unwrap when a user accidentally add as file instead of a dir in the cwd
src/task/task_hash.rs
Outdated
}; | ||
|
||
let files = | ||
FileHashes::from_files(&task.working_directory().unwrap(), outputs.iter()).await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here aswell
TODO: