fix: pypi dependencies not being removed #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdejager
changed the title
ruben-arts
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the situation where pypi dependencies were not removed from the prefix, while they were removed in the toml.
The problem was that if you have a single pypi dependency and removed this, the project would say it does not have pypi dependencies and the updating of the pypi prefix was never done.
This bug was introduced by me in #863, I think it would be nice to skip this code in the right situation, but seeing as this is a pretty big bug. I think its prudent to use this PR for now.
But hey 🤷♂️ , at least we have an add/remove tested now, and the test cli has expanded a bit.
@ruben-arts I've noticed there is also not a test for the conda situation here, maybe we should add it as well.