Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefix_file rename #959

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

ruben-arts
Copy link
Contributor

@ruben-arts ruben-arts commented Mar 12, 2024

fixes: #946

Users still need to delete the .pixi/envs/default/prefix file manually after updating if it forms an issue for their solara installation

@baszalmstra
Copy link
Contributor

Couldnt we not place this file in the .pixi folder instead of in the environment folder?

@ruben-arts
Copy link
Contributor Author

ruben-arts commented Mar 12, 2024

Couldnt we not place this file in the .pixi folder instead of in the environment folder?

We previously discussed to keep the file close to the environment. So yeah we could but I don't remember why we decided to do it this way.

@wolfv
Copy link
Member

wolfv commented Mar 13, 2024

@baszalmstra I think it should ideally be placed in the conda-meta folder. We seem to have a bug where rattler thinks all files in teh conda-meta folder are JSON though.

Conda does put a history and a urls.txt file there that also record some additional metadata.

@wolfv
Copy link
Member

wolfv commented Mar 14, 2024

@ruben-arts I think you could try moving this file into conda-meta now. As long as it doesn't end with .json it should be OK.

@wolfv wolfv merged commit 713d94b into prefix-dev:main Mar 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"prefix" is breaking if library overwrites jupyter settings in prefix
3 participants