-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add reactivation to pixi shell #982
Conversation
not sure i like this behavior :/ seems a bit too hacky |
@pavelzw unfortunately there is not really a way around it and it's exactly what conda/mamba/micromamba do. The re-hashing is the crucial step... |
Using direnv with |
yeah, but not everyone uses direnv 😱 I think the change is reasonable enough, and also does something in |
I guess if this is the most magic that it's getting and the shell hook is not used globally but only for
Not sure if this is much better than adding a shell function for pixi, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that this is a bit magic but I also dont see another way to solve this other than only printing a warning.
At the moment this now only works for shells other than zsh and bash. What if we add a check to pixi add
and co to see if you are in a shell and print a warning if thats the case? That requires no magic and should help people that use better shells for which no magic is (yet) implemented.
I also tested this with I did not test on Windows with
Not sure if these have the problem or not. In any case, even without testing those, I think it's a good change. |
I think as it stands it's a "strict improvement" over the current state. However, IMO we can merge this, open a new issue, and take it from there. |
TODO:
fixes #326 #977