Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip noarch build if --noarch-platform == build_platform #1192

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Nov 13, 2024

See #1175 for context.

When --noarch-platform is set, the noarch builds will be skipped if they are being built on a different platform than the platform set.


It's an opinionated flag, and the idea is to make it easy to build single repos rattler-based forge. By setting this flag to linux-64 for example, all the noarch packages of the forge will be only built on the linux-64 CI runs and not the others.

If that too specific for rattler-build, let me know and I will close.

@hadim hadim closed this Nov 13, 2024
@hadim hadim reopened this Nov 13, 2024
@wolfv
Copy link
Member

wolfv commented Nov 14, 2024

I did a tiny bit of cleanup to remove the unwrap :)

I am wondering if we shoudl call this --noarch-build-platform=..., and similar in the code. I think that would make it very clear? What do you think @hadim?

@hadim
Copy link
Contributor Author

hadim commented Nov 14, 2024

I did a tiny bit of cleanup to remove the unwrap :)

Thanks!

I am wondering if we shoudl call this --noarch-build-platform=..., and similar in the code. I think that would make it very clear? What do you think @hadim?

I switched to --noarch-build-platform.

LGTM.

@wolfv wolfv enabled auto-merge (squash) November 14, 2024 15:47
@wolfv wolfv disabled auto-merge November 14, 2024 15:47
@wolfv wolfv enabled auto-merge (squash) November 14, 2024 15:47
@wolfv wolfv merged commit 5e83d19 into prefix-dev:main Nov 14, 2024
17 of 19 checks passed
@hadim hadim deleted the skip_noarch_platform branch November 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants